Skip to content

[cloud_hotfix_releases] MGMT-17412: Change fallbck behavior when error occuring in OpenShift Release Syncer - #6166

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6145-to-cloud_hotfix_releases
Apr 9, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6145-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6145

/assign rccrdpccl

…Release Syncer - if there are release images already in the DB, continue using the stale data instead of failing / truncating the table
@openshift-ci-robot

openshift-ci-robot commented Apr 9, 2024 •

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17412

Details

In response to this:

This is an automated cherry-pick of #6145

/assign rccrdpccl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rccrdpccl

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2024
@openshift-ci
openshift-ci Bot requested review from carbonin and gamli75 April 9, 2024 08:39
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@codecov

codecov Bot commented Apr 9, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 68.34%. Comparing base (ef0c961) to head (54c96c0).
Report is 986 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6166      +/-   ##
=========================================================
+ Coverage                  66.66%   68.34%   +1.67%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    36050    +8524     
=========================================================
+ Hits                       18350    24638    +6288     
- Misses                      7531     9285    +1754     
- Partials                    1645     2127     +482     
Files Coverage Δ
internal/releasesources/release_sources.go 69.04% <0.00%> (ø)
internal/versions/common.go 56.12% <0.00%> (ø)

... and 158 files with indirect coverage changes

@danmanor

danmanor commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@danmanor

danmanor commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

/retest

@rccrdpccl

Copy link
Copy Markdown
Contributor

/override ci/prow/subsystem-aws

was passing in master, can't see why it shouldn't pass here
the issue is that we struggle to fulfill the claim

@rccrdpccl

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2024
@openshift-ci-robot

openshift-ci-robot commented Apr 9, 2024 •

Copy link
Copy Markdown

@rccrdpccl: This pull request references MGMT-17412 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/subsystem-aws

Details

In response to this:

/override ci/prow/subsystem-aws

was passing in master, can't see why it shouldn't pass here
the issue is that we struggle to fulfill the claim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danmanor

danmanor commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

/override ci/prow/subsystem-aws

@danmanor

danmanor commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

/override subsystem-aws

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • subsystem-aws

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-metal-assisted-day2
  • ci/prow/e2e-metal-assisted-ipv4v6
  • ci/prow/e2e-metal-assisted-onprem
  • ci/prow/e2e-metal-assisted-single-node
  • ci/prow/e2e-metal-assisted-static-ip-suite
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/subsystem-aws
  • ci/prow/unit-test
  • ci/prow/verify-generated-code
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-day2
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-onprem
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-single-node
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-lint
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-subsystem-aws
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-unit-test
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-verify-generated-code
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override subsystem-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/subsystem-aws

Details

In response to this:

/override ci/prow/subsystem-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit c867384 into openshift:cloud_hotfix_releases Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants